Added new connector: source-google-analytics-data-api #1366
Conversation
copying the image behaviour
Remote Repo URL: git@github.com:airbytehq/airbyte.git Source name: 019153f Source Commit ID: 019153f178d221bbf602c21efea54f78042544ca Source Repo Prefix: airbyte-integrations/connectors/source-google-analytics-data-api/ Import Path: source-google-analytics-data-api/ License Type: MIT License Path: airbyte-integrations/connectors/source-google-analytics-data-api/metadata.yaml git-merge-subpath: 019153f178d221bbf602c21efea54f78042544ca airbyte-integrations/connectors/source-google-analytics-data-api source-google-analytics-data-api
Modified spec.json to match fixups
At this point in time, all test pass added to CI
| "object" | ||
| ] | ||
| }, | ||
| "key": [ | ||
| "/date", | ||
| "/property_id" | ||
| "/property_id", |
There was a problem hiding this comment.
It's crucially important that we not change around the ordering of keys, and also the schematization of keyed fields like property_id here.
There is a good reason why we had previously made them non-nullable (downstream materializations typically cannot support nullable primary keys).
Fixing this will require tweaking the schemas and keys of the connector streams. This is essentially re-applying patches we had previously used in airbyte-to-flow.
(Getting this right is the central reason I've been asking for this snapshot -> import -> update snapshots -- so that we can verify in review that nothing is changing unintentionally).
There was a problem hiding this comment.
Got it, thanks for the info, this made everything more clear, will close the PR
Description:
(Describe the high level scope of new or changed features)
Notes for reviewers:
(anything that might help someone review this PR)
This change is