Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facebook: ads_insights primary keys must be non-nullable #1377

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

mdibaiee
Copy link
Member

@mdibaiee mdibaiee commented Mar 15, 2024

Description:

  • Mark primary keys as required and make sure their type does not have null in it

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

@mdibaiee mdibaiee force-pushed the mahdi/fb-keys branch 2 times, most recently from 8e54389 to 3e85840 Compare March 15, 2024 15:52
Copy link
Member

@dyaffe dyaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dyaffe dyaffe merged commit a9ec02d into main Mar 15, 2024
51 of 53 checks passed
@mdibaiee mdibaiee deleted the mahdi/fb-keys branch March 16, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants