Enable primary_key for custom queries in source-google-ads #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a customer who is trying to add custom queries to the source-google-ads connector. The errors was caused by the lack of primary keys for the CustomQueryMixin stream, this PR enables it.
Z33DD
force-pushed
the
source-google-ads/add-query-support
branch
from
f692b24 to
92a20cc
Compare
|
Closing this per #1486, where broader work for enabling this is tracked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We have a customer who is trying to add custom queries to the source-google-ads connector. The errors were caused by the lack of primary keys for the
CustomQueryMixinstream, this PR enables it.This change is