Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-zendesk-support: checkpoint TicketMetricEvents state after every 1000 documents #2014

Merged

Conversation

Alex-Bair
Copy link
Contributor

@Alex-Bair Alex-Bair commented Oct 3, 2024

Description:

Previously, TicketMetricEvents was only emitting documents and checkpointing state after reading all available documents from Zendesk Support & getting caught up to the present. TicketMetricEvents can take multiple hours to backfill, and any task restarts during the backfill cause TicketMetricEvents to start over completely instead of picking back up where it left off before the restart.

Setting state_checkpoint_interval tells TickeMetricEvents to checkpoint state & emit documents after every 1000 documents, and this allows the stream to pick up where it left off if it's interrupted during a backfill.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

Tested on a local stack. Confirmed that TicketMetricEvents checkpoints state after every 1000 documents and uses the most recently checkpointed state if it's interrupted during a sweep/backfill.


This change is Reviewable

…very 1000 documents

Previously, `TicketMetricEvents` was only emitting documents and
checkpointing state after reading all available documents from Zendesk
Support. `TicketMetricEvents` can take multiple hours to backfill, and
any task restarts during the backfill caused `TicketMetricEvents` to
start over completely instead of picking back up where it left off
before the restart.

Setting `state_checkpoint_interval` tells `TickeMetricEvents` to
checkpoint state & emit documents after every 1000 documents and allows
the stream to pick up where it left off if it's interrupted during a
backfill.
@Alex-Bair Alex-Bair added the change:unplanned Unplanned change, useful for things like doc updates label Oct 3, 2024
@Alex-Bair Alex-Bair requested a review from a team October 3, 2024 15:52
Copy link
Member

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alex-Bair Alex-Bair merged commit 73d6382 into main Oct 3, 2024
68 of 75 checks passed
@Alex-Bair Alex-Bair deleted the bair/zendesk-support-ticketmetricevents-state-checkpoint branch October 3, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:unplanned Unplanned change, useful for things like doc updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants