Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-pendo: validate API key #2020

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

Alex-Bair
Copy link
Contributor

@Alex-Bair Alex-Bair commented Oct 4, 2024

Description:

Previously, users could successfully create a task with an invalid Pendo API key. Pendo returns a 403 code when we send a request with an invalid API key, and we now key off that to prevent tasks with invalid API keys from being created.

A screenshot of the error rendered in the UI is below:
image

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

Tested on a local stack. Confirmed:

  • an error is thrown before task creation when an invalid API key is provided.
  • tasks can still be created with a valid API key.

This change is Reviewable

Previously, users could successfully create tasks with an invalid Pendo
API key. Pendo returns a `403` code when we send a requests with an
invalid API key, and we now key off that to prevent tasks with invalid
API keys from being created.
@Alex-Bair Alex-Bair added the change:unplanned Unplanned change, useful for things like doc updates label Oct 4, 2024
Copy link
Member

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alex-Bair Alex-Bair merged commit c7c25f7 into main Oct 4, 2024
69 of 75 checks passed
@Alex-Bair Alex-Bair deleted the bair/pendo-api-key-validation branch October 4, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:unplanned Unplanned change, useful for things like doc updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants