Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-zendesk-support: omit tags from capture snapshot #2044

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Alex-Bair
Copy link
Contributor

@Alex-Bair Alex-Bair commented Oct 11, 2024

Description:

The /tags endpoint returns the most popular tags used in the last 60 days. After 60 days, it's possible for existing tags to not be returned if they weren't used recently. Because we aren't going into Zendesk & using tags every once in a while, the capture snapshot has been failing in CI. Instead of making a reminder to go into Zendesk every 2 months and use a tag, I think it's easier to just remove tags from the capture snapshot.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

Confirmed snapshot tests passed locally.


This change is Reviewable

The `/tags` endpoint returns the most popular tags used in the last 60
days. After 60 days, it's possible for existing tags to not be returned
if they weren't used recently. The capture snapshot has been failing in
CI because of this. Instead of making a reminder to go into Zendesk
every 2 months and use a tag, I think it's easier to just remove tags
from the capture snapshot.
@Alex-Bair Alex-Bair added the change:unplanned Unplanned change, useful for things like doc updates label Oct 11, 2024
Copy link
Member

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alex-Bair Alex-Bair merged commit 917e2c3 into main Oct 14, 2024
72 of 76 checks passed
@Alex-Bair Alex-Bair deleted the bair/zendesk-capture-snapshot branch October 14, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:unplanned Unplanned change, useful for things like doc updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants