source-facebook-marketing: support multiple account ids #2162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The main change in this PR is supporting multiple Facebook Marketing account IDs in a single connector. Multiple account IDs can be provided as comma separated values in the
account_ids
field. This change is backwards compatible with older configs that only have anaccount_id
field.The account ID is used in multiple locations throughout the connector, and many of the changes are for threading the account ID through all streams.
Supporting more than one account ID in the connector also means that streams need to retain a cursor per account ID. The various state management tools (
get_updated_state
,stream_slices
, thestate
property, etc.) have been updated to retain a cursor value for each account ID.Closes #2110
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
The
source-facebook-marketing
documentation should be updated to reflect that multiple account IDs are supported. The docs update PR will be linked here once it's ready.Notes for reviewers:
Tested on a local stack with a single account ID and a recent start date (01NOV2024). Confirmed that:
account_ids
without error.Spec and discover snapshot changes are expected due to adding support for multiple account IDs & updating the documentation URLs.
This change is