source-hubspot-native: bindings for owners, deal pipelines, products, and line items #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds 2 new snapshot bindings, for owners and deal pipelines. Also turned off the "properties" bindings for tests since it was a huge response that was spamming everything else out.
Adds a new incremental binding for "products". This probably could be a snapshot binding but it is easier to use the existing property fetching stuff we have for other incremental bindings already, and it's theoretically possible that somebody will have a large number of rapidly changing products. We don't have any "product" objects in our test account and I don't feel like figuring out how to add any, so the capture snapshot output is unchanged.
Adds a new incremental binding for "line items". Like "products", we don't have any "line items" in our test account and I'm not going to put any in there so the capture snapshot output is unchanged.
williamhbaker
force-pushed
the
wb/hsn-more-streams
branch
from
fbf6939 to
5be042d
Compare
Alex-Bair
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds new bindings for owners, deal pipelines, products, and line items.
As noted in the commit messages, for products and line items we don't have data in our test account and I'm not going to add any, so the test snapshots are unchanged for those. I did manually test that the results are as expected on a a HubSpot account that has data for those bindings though.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
HubSpot native docs will need updated.
Notes for reviewers:
(anything that might help someone review this PR)
This change is