Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-http-ingest: add CORS support #2173

Merged
merged 1 commit into from
Nov 27, 2024
Merged

source-http-ingest: add CORS support #2173

merged 1 commit into from
Nov 27, 2024

Conversation

psFried
Copy link
Member

@psFried psFried commented Nov 27, 2024

Supports CORS preflight requests on an opt-in basis. The goal is to allow the users to capture data directly from browsers. A list of allowed origins was added to the endpoint config. If left empty (the default), then cors will be disabled entirely. A non-empty list will enable cors for the specific origins listed. As a special case, * may be used to permit any origin.


This change is Reviewable

@psFried psFried added enhancement New feature or request rust Pull requests that update Rust code change:unplanned Unplanned change, useful for things like doc updates labels Nov 27, 2024
Supports CORS preflight requests on an opt-in basis. The goal is to allow the
users to capture data directly from browsers. A list of allowed origins was
added to the endpoint config. If left empty (the default), then cors will be
disabled entirely. A non-empty list will enable cors for the specific origins
listed. As a special case, `*` may be used to permit any origin.
@williamhbaker williamhbaker self-requested a review November 27, 2024 16:39
Copy link
Member

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psFried psFried merged commit c3518cc into main Nov 27, 2024
52 of 53 checks passed
@psFried psFried deleted the phil/webhook-cors branch November 27, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:unplanned Unplanned change, useful for things like doc updates enhancement New feature or request rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants