source-stripe-native: query for payment_method.detached event
#2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Bair
added
the
change:unplanned
Stripe added `outcome.network_advice_code` and `network_decline_code` fields to various streams. This broke our capture snapshot test. It'd be nice if this type of backwards-compatible field addition was automatically handled in capture snapshots for SaaS connectors somehow. Doing that sounds like a relatively large lift with little immediate benefit, so this PR just updates the capture snapshot so tests pass. The docs URL is also updated to actually point to the appropriate connector docs.
We've been seeing a significant number of rate-limiting errors, and users have seen their other Stripe integrations getting rate-limited because the connector sends a massive number of API requests. Increasing the default interval to 5 minutes should help reduce the number of API requests the connector makes. Other improvements could be made to reduce the number of API requests the connector makes. Primarily, the connector could dispatch events to different bindings based on the event type instead of having each binding check the `/events` endpoint. However, that's a significant refactor that will take some time & should be prioritized against all of the other work that needs done.
Alex-Bair
force-pushed
the
bair/stripe-native-payment-method-detached-event
branch
from
bbeefa9 to
ba96ee6
Compare
Alex-Bair
deleted the
bair/stripe-native-payment-method-detached-event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR's scope includes:
payment_method.detachedevent as an event thePaymentMethodsstream listens for during incremental replication.payment_method.detachedevents as updates rather than deletes.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
Docs don't currently exist for this connector, but they should be created.
Notes for reviewers:
Confirmed that:
payment_method.detachedevents are generated by Stripe and are accessible via the/eventsendpoint.PaymentMethodsstream replicates data on a local stack.This change is