source-postgres: Handle null restart_lsn values #2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When querying replication slot info for an invalidated slot, the `restart_lsn` column is typically null which resulted in a: ``` error querying replication slots: can't scan into dest[5]: can not scan <nil> to LSN ``` warning rather than the intended behavior where the query itself succeeds and because `wal_status == 'lost'` we instead warn that: ``` replication slot was invalidated by the server, it must be deleted and all bindings backfilled ``` Note that in either case this is currently just a warning and the actual error today is still: ``` runTransactions: readMessage: error creating replication stream: unable to start replication: ERROR: cannot read from logical replication slot "flow_slot" (SQLSTATE 55000) ``` I would like to get the logic working reliably in warn-mode before we make it a hard error, for obvious reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying replication slot info for an invalidated slot, the
restart_lsncolumn is typically null which resulted in a:warning rather than the intended behavior where the query itself succeeds and because
wal_status == 'lost'we instead warn that:Note that in either case this is currently just a warning and the actual error today is still:
I would like to get the logic working reliably in warn-mode before we make it a hard error, for obvious reasons.
This change is