Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-braintree-native: change window size from days to hours #2191

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

Alex-Bair
Copy link
Contributor

@Alex-Bair Alex-Bair commented Dec 9, 2024

Description:

Users have enough data in Braintree that a window size of 1 day (the smallest previously possible) wasn't small enough to ensure the connector wasn't missing data. Window size is now specified in hours, with the default updated to 24 hours.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

@Alex-Bair Alex-Bair marked this pull request as ready for review December 9, 2024 21:48
@Alex-Bair Alex-Bair requested a review from a team December 9, 2024 21:49
Copy link
Member

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alex-Bair Alex-Bair merged commit e637677 into main Dec 9, 2024
74 of 79 checks passed
@Alex-Bair Alex-Bair deleted the bair/source-braintree-native-window-size-in-hours branch December 9, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants