Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-braintree-native: fix nullable key on full refresh resources #2192

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

Alex-Bair
Copy link
Contributor

@Alex-Bair Alex-Bair commented Dec 9, 2024

Description:

Keys on full refresh resources need to be non-nullable. The key for these resources is now _meta/row_id instead of id.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

@Alex-Bair Alex-Bair marked this pull request as ready for review December 9, 2024 22:17
Copy link
Member

@dyaffe dyaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alex-Bair Alex-Bair merged commit 1c80e71 into main Dec 9, 2024
74 of 79 checks passed
@Alex-Bair Alex-Bair deleted the bair/braintree-nullable-key-fix branch December 9, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants