From ad4f1def322f12e1ca36ddf49d7c4111551f2552 Mon Sep 17 00:00:00 2001 From: Danny Ryan Date: Thu, 22 Jun 2023 10:01:49 -0600 Subject: [PATCH] Apply suggestions from code review --- specs/deneb/beacon-chain.md | 8 +++++--- specs/deneb/fork-choice.md | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/specs/deneb/beacon-chain.md b/specs/deneb/beacon-chain.md index 9228a7d8f3..abc1403d53 100644 --- a/specs/deneb/beacon-chain.md +++ b/specs/deneb/beacon-chain.md @@ -231,6 +231,8 @@ class NewPayloadRequest(object): ##### `is_valid_block_hash` +*Note*: The function `is_valid_block_hash` is modified to include the additional `parent_beacon_block_root` parameter for EIP-4788. + ```python def is_valid_block_hash(self: ExecutionEngine, execution_payload: ExecutionPayload, @@ -275,7 +277,7 @@ def verify_and_notify_new_payload(self: ExecutionEngine, execution_payload = new_payload_request.execution_payload parent_beacon_block_root = new_payload_request.parent_beacon_block_root - # [New in Deneb:EIP4788] + # [Modified in Deneb:EIP4788] if not self.is_valid_block_hash(execution_payload, parent_beacon_block_root): return False @@ -283,7 +285,7 @@ def verify_and_notify_new_payload(self: ExecutionEngine, if not self.is_valid_versioned_hashes(new_payload_request): return False - # [New in Deneb:EIP4788] + # [Modified in Deneb:EIP4788] if not self.notify_new_payload(execution_payload, parent_beacon_block_root): return False @@ -354,7 +356,7 @@ def process_execution_payload(state: BeaconState, body: BeaconBlockBody, executi # Verify the execution payload is valid # [Modified in Deneb:EIP4844] Pass `versioned_hashes` to Execution Engine - # [Modified in Deneb:EIP4788] Pass parent beacon block root to Execution Engine + # [Modified in Deneb:EIP4788] Pass `parent_beacon_block_root` to Execution Engine versioned_hashes = [kzg_commitment_to_versioned_hash(commitment) for commitment in body.blob_kzg_commitments] assert execution_engine.verify_and_notify_new_payload( NewPayloadRequest( diff --git a/specs/deneb/fork-choice.md b/specs/deneb/fork-choice.md index d7d2eaa2fc..23eef436c1 100644 --- a/specs/deneb/fork-choice.md +++ b/specs/deneb/fork-choice.md @@ -26,7 +26,7 @@ This is the modification of the fork choice accompanying the Deneb upgrade. ### Extended `PayloadAttributes` -`PayloadAttributes` is extended with the parent beacon block root. +`PayloadAttributes` is extended with the parent beacon block root for EIP-4788. ```python @dataclass