From 74c2440416f9dcd2472d4d19203bae6ac359b8a7 Mon Sep 17 00:00:00 2001 From: Nikola Matic Date: Wed, 25 Oct 2023 12:45:23 +0200 Subject: [PATCH 1/2] Update the release checklist --- ReleaseChecklist.md | 1 + 1 file changed, 1 insertion(+) diff --git a/ReleaseChecklist.md b/ReleaseChecklist.md index db07fb888555..505852496f83 100644 --- a/ReleaseChecklist.md +++ b/ReleaseChecklist.md @@ -58,6 +58,7 @@ At least a day before the release: Remove different variants of the same name manually before using the output. - [ ] Check that all tests on the latest commit in ``develop`` are green. - [ ] Click the ``Publish release`` button on the release page, creating the tag. + **Important: Must not be done before all the PRs, including changelog cleanup and date, are merged.** - [ ] Wait for the CI runs on the tag itself. ### Upload Release Artifacts and Publish Binaries From 79b1f55cc51334cee7a38364bdcb0599702dd598 Mon Sep 17 00:00:00 2001 From: Nikola Matic Date: Thu, 26 Oct 2023 13:42:55 +0200 Subject: [PATCH 2/2] Remove references to homebrew-ethereum --- ReleaseChecklist.md | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ReleaseChecklist.md b/ReleaseChecklist.md index 505852496f83..db8bd426b66d 100644 --- a/ReleaseChecklist.md +++ b/ReleaseChecklist.md @@ -2,8 +2,7 @@ ### Requirements - [ ] GitHub account with access to [solidity](https://github.com/ethereum/solidity), [solc-js](https://github.com/ethereum/solc-js), - [solc-bin](https://github.com/ethereum/solc-bin), [homebrew-ethereum](https://github.com/ethereum/homebrew-ethereum), - [solidity-website](https://github.com/ethereum/solidity-website). + [solc-bin](https://github.com/ethereum/solc-bin), [solidity-website](https://github.com/ethereum/solidity-website). - [ ] DockerHub account with push rights to the [``solc`` image](https://hub.docker.com/r/ethereum/solc). - [ ] Launchpad (Ubuntu One) account with a membership in the ["Ethereum" team](https://launchpad.net/~ethereum) and a gnupg key for your email in the ``ethereum.org`` domain (has to be version 1, gpg2 won't work). @@ -21,7 +20,6 @@ At least a day before the release: - [ ] Rerun CI on the top commits of main branches in all repositories that do not have daily activity by creating a test branch or PR: - [ ] ``solc-js`` - [ ] ``solc-bin`` (make sure the bytecode comparison check did run) - - [ ] ``homebrew-ethereum`` - [ ] (Optional) Create a prerelease in our Ubuntu PPA by following the steps in the PPA section below on ``develop`` rather than on a tag. This is recommended especially when dealing with PPA for the first time, when we add a new Ubuntu version or when the PPA scripts were modified in this release cycle. - [ ] Verify that the release tarball of ``solc-js`` works. @@ -74,7 +72,6 @@ At least a day before the release: ### Homebrew and MacOS - [ ] Update the version and the hash (``sha256sum solidity_$VERSION.tar.gz``) in the [``solidity`` formula in Homebrew core repository](https://github.com/Homebrew/homebrew-core/blob/master/Formula/solidity.rb). - - [ ] Update the version and the hash (``sha256sum solidity_$VERSION.tar.gz``) in [our custom ``solidity`` Homebrew formula](https://github.com/ethereum/homebrew-ethereum/blob/master/solidity.rb). ### Docker - [ ] Run ``./scripts/docker_deploy_manual.sh v$VERSION``.