Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common: consistent GasPrices naming #3037

Open
Tracked by #3216
acolytec3 opened this issue Sep 18, 2023 · 2 comments
Open
Tracked by #3216

Common: consistent GasPrices naming #3037

acolytec3 opened this issue Sep 18, 2023 · 2 comments

Comments

@acolytec3
Copy link
Contributor

As discovered in #3035, the casing of the GasPrices subkeys in common/src/eips.ts is not consistent. This should be fixed and then simplify the code in places like in the getBaseFee helper where we call toLowerCase to remove this additional check (which in theory should also provide a small performance gain).

@acolytec3 acolytec3 self-assigned this Sep 18, 2023
@holgerd77
Copy link
Member

Just to add that this is a breaking change since these names are part of the public Common API, so we can't do these updates right now.

@holgerd77 holgerd77 changed the title Make all GasPrices config keys lower case Common: consistent GasPrices naming Jan 8, 2024
@holgerd77
Copy link
Member

Have given this a more neutral title (I somewhat do like the camel case naming, so I would like to at least give this one additional round of thought what we do here (all lowercase vs consistent camel case). No dramatically strong opinion though. 😋

Will also add to the new breaking release tracking issue I created #3216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants