You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As discovered in #3035, the casing of the GasPrices subkeys in common/src/eips.ts is not consistent. This should be fixed and then simplify the code in places like in the getBaseFee helper where we call toLowerCase to remove this additional check (which in theory should also provide a small performance gain).
The text was updated successfully, but these errors were encountered:
Have given this a more neutral title (I somewhat do like the camel case naming, so I would like to at least give this one additional round of thought what we do here (all lowercase vs consistent camel case). No dramatically strong opinion though. 😋
Will also add to the new breaking release tracking issue I created #3216
As discovered in #3035, the casing of the
GasPrices
subkeys incommon/src/eips.ts
is not consistent. This should be fixed and then simplify the code in places like in thegetBaseFee
helper where we calltoLowerCase
to remove this additional check (which in theory should also provide a small performance gain).The text was updated successfully, but these errors were encountered: