-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Use smart contract-based binary search to find userop gas limits #211
Comments
I'm taking a look into this. |
Thank you @nikhilkumar1612 Do give us a shout if you have any questions. |
hey i have a few questions:
|
Hi @nikhilkumar1612 thanks for picking up this issue!
Let me know if you have more questions! |
thanks @0xSulpiride . I have completed the changes needed for the types, |
@nikhilkumar1612 this is only relevant to v7 |
Thank you @nikhilkumar1612 Please create a PR when ready. |
hi guys please find my PR and let me know the changes. |
Is your feature request related to a problem? Please describe.
Skandha started to misestimate gas limits of userops that use EntryPoint v0.7.0.
We need to switch to smart-contract based binary search algorithm for better estimation of gas limits.
Describe the solution you'd like
We should implement the same approach that Rundler does.
They use this contract: https://github.com/alchemyplatform/rundler/blob/307e8c2cbeab80518a56a2f309e994de3b1631f0/crates/types/contracts/src/v0_7/CallGasEstimationProxy.sol
The text was updated successfully, but these errors were encountered: