From 764b7dc0577a8e8da9dac3519d18db51720f2b4b Mon Sep 17 00:00:00 2001 From: Gyanendra Mishra Date: Mon, 6 Nov 2023 14:09:43 +0000 Subject: [PATCH] fix: network params setting invalid value for min/max configs (#353) --- .github/workflows/per-pr.yml | 1 + README.md | 24 ++++++++++++------------ network_params.yaml | 24 ++++++++++++------------ 3 files changed, 25 insertions(+), 24 deletions(-) diff --git a/.github/workflows/per-pr.yml b/.github/workflows/per-pr.yml index 3834b3200..89c6c5b9c 100644 --- a/.github/workflows/per-pr.yml +++ b/.github/workflows/per-pr.yml @@ -32,6 +32,7 @@ jobs: "./.github/tests/mev.yaml", "./.github/tests/mev-mock.yaml", "./.github/tests/mix-with-tools.yaml", + "./network_params.yaml" ] runs-on: ubuntu-latest steps: diff --git a/README.md b/README.md index adf282cc4..55a2bc1bc 100644 --- a/README.md +++ b/README.md @@ -169,18 +169,18 @@ participants: # CPU is milicores # RAM is in MB # Defaults are set per client - el_min_cpu: '' - el_max_cpu: '' - el_min_mem: '' - el_max_mem: '' - bn_min_cpu: '' - bn_max_cpu: '' - bn_min_mem: '' - bn_max_mem: '' - v_min_cpu: '' - v_max_cpu: '' - v_min_mem: '' - v_max_mem: '' + el_min_cpu: 0 + el_max_cpu: 0 + el_min_mem: 0 + el_max_mem: 0 + bn_min_cpu: 0 + bn_max_cpu: 0 + bn_min_mem: 0 + bn_max_mem: 0 + v_min_cpu: 0 + v_max_cpu: 0 + v_min_mem: 0 + v_max_mem: 0 # Snooper can be enabled with the `snooper_enabled` flag per client or globally # Defaults to false diff --git a/network_params.yaml b/network_params.yaml index 358c12d87..e5c6c2322 100644 --- a/network_params.yaml +++ b/network_params.yaml @@ -12,18 +12,18 @@ participants: validator_count: null snooper_enabled: false ethereum_metrics_exporter_enabled: false - el_min_cpu: '' - el_max_cpu: '' - el_min_mem: '' - el_max_mem: '' - bn_min_cpu: '' - bn_max_cpu: '' - bn_min_mem: '' - bn_max_mem: '' - v_min_cpu: '' - v_max_cpu: '' - v_min_mem: '' - v_max_mem: '' + el_min_cpu: 0 + el_max_cpu: 0 + el_min_mem: 0 + el_max_mem: 0 + bn_min_cpu: 0 + bn_max_cpu: 0 + bn_min_mem: 0 + bn_max_mem: 0 + v_min_cpu: 0 + v_max_cpu: 0 + v_min_mem: 0 + v_max_mem: 0 count: 2 network_params: network_id: '3151908'