feat(output/kafka-sink) #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
samcm
reviewed
Oct 16, 2023
* fix typos. * Use flushBytes as a reference to check against msgByteSize.
* fix topic validation.
00x-dx
force-pushed
the
feat/kafka-sink
branch
from
6ffa2c9
to
cb7f11f
Compare
00x-dx
force-pushed
the
feat/kafka-sink
branch
from
72bbf2f
to
5718e0d
Compare
|
Thank you @0x-dx! This looks absolutely perfect. I'm away for the remainder of the week, I'll merge this on Monday and give it a spin! 🚀 |
samcm
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Kafka sink output.