Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the number of rows and columns of april grid are limited to a minimum of 3 #609

Open
Ruthrash opened this issue Apr 17, 2023 · 3 comments
Labels
debugging Might be a bug, needs to be looked into

Comments

@Ruthrash
Copy link

if not isinstance(tagRows,int) or tagRows < 3:

Any prinicipled reason for limitied minimum number of rows and columns to 3?

@goldbattle goldbattle added the question Theory or implementation question label Apr 17, 2023
@goldbattle
Copy link
Collaborator

I believe this is because it is detecting the inner corners of the checkerboard, which is not possible with less than 3 rows or columns. Maybe you could search about OpenCV's checkerboard detection to understand more.

@Ruthrash Ruthrash reopened this Apr 17, 2023
@Ruthrash
Copy link
Author

I understand that's the case for the checkerboard, but my question was for the april grid. I can think of no reason why we need to limit it for the april grid case

@goldbattle goldbattle added debugging Might be a bug, needs to be looked into and removed question Theory or implementation question labels Jul 20, 2023
@goldbattle
Copy link
Collaborator

Very true, would need to test to see if that gives good results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debugging Might be a bug, needs to be looked into
Projects
None yet
Development

No branches or pull requests

2 participants