Strict mode

[Turbo87]

🍩 Feature Request

Is your feature request related to a problem? Please describe.

In a few of our apps the testing setup is a little incomplete which sometimes causes "svg could not be found" warnings on the console. I'd like to ensure that such warnings are not ignored, by making the test fail when an inlined SVG could not be found.

Describe the solution you'd like

I was thinking that maybe a strict: true/false option could be added to the svgJar object in the ember-cli-build.js file. To not make this a breaking change it would be false by default, but people could set it to true for their dev and test environment builds.

The makeSvg() helper would then look at the state of that flag and either console.warn() like we do today, or throw new Error() if strict is true.

Describe alternatives you've considered

export function enableStrictSvgJar() {
  let originalWarn = console.warn;
  console.warn = function (...args) {
    if (args.length > 0 && args[0].startsWith('ember-svg-jar: ')) {
      throw new Error(args[0]);
    }

    originalWarn.call(console, ...args);
  };
}

I've hacked it together for now, but this is probably not a good long-term solution to the problem.

Additional context

[voltidev]

That makes sense. Please feel free to make a PR for the feature. And let me know if something is not clear in the addon's code.

[Turbo87]

hmm, thinking some more about this, I guess it would also be nice if in production mode we could trigger a Sentry error report instead of showing the warnings, so maybe it would be better to generally be able to overwrite the warning handler. 🤔