-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
svgo 2 throws "SVGO is not a constructor" #193
Labels
Comments
It's my intention to migrate this addon to v2 once I sort out a few test failures with the current code. If you're interested, a pull request migrating to v2 would be accepted as well. |
I just ran in to this with svgo 3 -- seems still a problem. |
@bertdeblock was working on a PR to upgrade svgo but it looks like he closed it Any plans to revisit this, what was the reason you closed the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐞 Bug Report
Describe the bug
Our Ember app supplies its own version of
svgo
toember-svg-jar
, via theoptimizer
config option: https://github.com/ivanvotti/ember-svg-jar/blob/master/docs/configuration.md#optimizer-can-be-redefined-on-a-strategy-levelIf we try to upgrade our app's version of
svgo
to >=2 (https://github.com/svg/svgo/releases/tag/v2.0.0), our app no longer builds. It throws an errorSVGO is not a constructor
.Full Stack Trace
Reproduce the bug
Expected behavior
Ember app builds should not crash, and SVGs should render as normal.
The text was updated successfully, but these errors were encountered: