Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover possibility of redirects to other origins within the popin #4

Closed
krgovind opened this issue Jul 2, 2024 · 3 comments · Fixed by #5
Closed

Cover possibility of redirects to other origins within the popin #4

krgovind opened this issue Jul 2, 2024 · 3 comments · Fixed by #5

Comments

@krgovind
Copy link

krgovind commented Jul 2, 2024

In privacycg/storage-partitioning/issues/28, @darkowic mentioned a use-case that involves a redirect/OIDC exchange with another SSO provider within the popin. Is that a scenario we can support with this proposal (assuming that state is still partitioned to the opener)?

@arichiv
Copy link
Collaborator

arichiv commented Jul 2, 2024

redirects within the popin are no issue, but the popin itself remains partitioned regardless of redirect/navigation destination and headers permitting the popin context are required of all pages loaded.

@krgovind
Copy link
Author

krgovind commented Jul 2, 2024

redirects within the popin are no issue, but the popin itself remains partitioned regardless of redirect/navigation destination and headers permitting the popin context are required of all pages loaded.

That makes sense. Any chance we can document this requirement/behavior in the explainer? I didn't spot it on a quick skim, apologies if it's already there!

@arichiv
Copy link
Collaborator

arichiv commented Jul 2, 2024

It's kind of addressed, but I could add more details:

Navigating to or redirecting through a page without a Popin-Policy that permits the opening context to do so will cause the popin to automatically close and report the error to the opening context.

arichiv added a commit that referenced this issue Jul 2, 2024
@arichiv arichiv closed this as completed in #5 Jul 2, 2024
arichiv added a commit that referenced this issue Jul 2, 2024
* Detail redirect/navigation handling

closes #4

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants