Bug with the router class

[evokerking1]

This is my code
``// import the route
import { playground } from "@colyseus/playground"
// ...
const monitor = require("@colyseus/monitor").monitor
const express = require("express")
const app = express
const route = app.Router

// ...
route.use("/monitor", monitor)

// bind it as an express middleware
route.use("/playground", playground)

app.listen(3000)

which throws this error

$ bun run index.js
478 | end: false
479 | }, fn);
480 |
481 | layer.route = undefined;
482 |
483 | this.stack.push(layer);
^
TypeError: undefined is not an object (evaluating 'this.stack.push')
at use (/workspace/colyseus-testing-ground/node_modules/express/lib/router/index.js:483:10)
at /workspace/colyseus-testing-ground/index.js:10:7

Bun v1.1.30 (Linux x64)
error: script "test" exited with code 1
and the code that throws this error in the /lib/router/index.js line 483 or this.layer.push()

[evokerking1]

Whats require-triage label?

[dpopp07]

@evokerking1 The Triage Process indicates that it means further triaging is needed to properly classify the issue.

[nwalters512]

You wrote const route = app.Router. Is this what's actually in your code? I'd recommend reviewing the docs, which make it clear that you must call Router. That is:

const router = app.Router()

[evokerking1]

You wrote const route = app.Router. Is this what's actually in your code? I'd recommend reviewing the docs, which make it clear that you must call Router. That is:

const router = app.Router()

That is all my code.

[IamLizu]

Hey @evokerking1 👋

The error occurs because app and Router need to be initialized with express() and express.Router() respectively, not just referenced.

const app = express()
const router = app.Router()

I hope it resolves your issue.

[shivam-sharma7]

Hey @evokerking1 👋

Like @nwalters512 pointed out, could you please confirm if the issue persists even after changing,

const route = app.Router

to,

Agree! this should work

const router = app.Router()

[evokerking1]

i tried that stuff but it stills throws an error

[krzysdz]

The answers above give only partially correct answers. The router's constructor (Router()) is a part of the "express" module, not the instance of the app.

const express = require("express"); // the express module

const app = express();              // instantiate the express app; note the `()` at the end
const router = express.Router();    // Router constructor is a part of the module (`express`), not `app`;
                                    // `()` also required

// This demo mounts a router `router` (with a simple GET handler on `/`) on `/r`
router.get("/", (req, res) => res.send("ok"));
app.use("/r", router);

const PORT = 8080;
const server = app.listen(PORT, async () => {
    const r = await fetch(`http://127.0.0.1:${PORT}/r/`);
    console.log(r.status, await r.text());
    server.close();
});

You can also find some examples in the documentation.