New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$this->EE->javascript->generate_json() doesn't exist anymore #6

Open

LouWii opened this issue Jan 23, 2015 · 0 comments

LouWii commented Jan 23, 2015

Hi,

I ran into an issue with your module because the $this->EE->javascript->generate_json() function doesn't exist anymore. (mod.cx_disqus.php)

I saw an other module that use this method to determine if you need to use it or not :

private function _get_json($data)
{
    if (version_compare(APP_VER, '2.6', '<') OR !function_exists('json_encode'))
    {
        return $this->EE->javascript->generate_json($data, TRUE);
    }
    else
    {
        return json_encode($data);
    }
}

I can make a pull request if you want ;)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment