Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Create shared parent classes for KFACLinearOperator and KFACInverseLinearOperator #126

Open
runame opened this issue Sep 17, 2024 · 0 comments
Open

[REF] Create shared parent classes for KFACLinearOperator and KFACInverseLinearOperator #126

runame opened this issue Sep 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@runame
Copy link
Collaborator

runame commented Sep 17, 2024

I think we should at some point refactor KFACLinearOperator and KFACInverseLinearOperator to inherit from KroneckerProductLinearOperator and EigendecomposedKroneckerProductLinearOperator (or similar) classes since torch_matmat and other methods can be shared. Also, currently KFACInverseLinearOperator doesn't support trace, det, etc. properties which can also be shared.
@runame runame added the enhancement New feature or request label Sep 17, 2024
@runame runame mentioned this issue Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@runame