Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening the class for customisation #28

Open
mcomissocdc opened this issue Jun 23, 2022 · 0 comments
Open

Opening the class for customisation #28

mcomissocdc opened this issue Jun 23, 2022 · 0 comments

Comments

@mcomissocdc
Copy link

Hey Franco, thanks for writing this!

I've added it to our Danger configuration, and I was looking into customising some features.

I have 2 problems at the moment:

  • that the filter function (Result) -> Bool does not give me the full context of the overall results
  • the summary does not expose a readable variable for warnings/errors either (this prevents me from creating my own warnings array to then Danger.warn() manually).

Example:
Compact these multiple warnings into a single message with an overview of the lines impacted by the same error/warning.

/path/to/file.swift#L123 Description of the issue
/path/to/file.swift#L234 Description of the issue
/path/to/file.swift#L345 Description of the issue
/path/to/file.swift#L123 + L234, L345: Description of the issue

Happy to write a PR about it, if it's aligned with the scope of the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant