Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable #744

Open
7 of 8 tasks
f1shl3gs opened this issue Feb 7, 2023 · 2 comments
Open
7 of 8 tasks

Configurable #744

f1shl3gs opened this issue Feb 7, 2023 · 2 comments
Milestone

Comments

@f1shl3gs
Copy link
Owner

f1shl3gs commented Feb 7, 2023

  • sources
  • transforms
  • sinks
  • extensions
  • providers
  • remove trait GenerateConfig
  • remove source_type, sink_type and so on
  • impl Configurable for config Builder
@f1shl3gs
Copy link
Owner Author

Removing typetag is not a easy job. If we want schema command works, Config or ConfigBuilder's sources, transforms, sinks, extensions and providers field should be refactored to an Enum which contains a lot #[cfg(...)] for each variant, it is not easy to mantain, and we have to move config from lib/framework to vertex.

@f1shl3gs
Copy link
Owner Author

f1shl3gs commented Feb 12, 2023

Removing typetag is not a easy job. If we want schema command works, Config or ConfigBuilder's sources, transforms, sinks, extensions and providers field should be refactored to an Enum which contains a lot #[cfg(...)] for each variant, it is not easy to mantain, and we have to move config from lib/framework to vertex.

If we create an enum contains all sources, then we don't need inventory anymore.

@f1shl3gs f1shl3gs changed the title migrate to configurable Configurable Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant