Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdep reverse depenency checks: spqdep failures #1

Open
rsbivand opened this issue Nov 22, 2023 · 4 comments
Open

spdep reverse depenency checks: spqdep failures #1

rsbivand opened this issue Nov 22, 2023 · 4 comments

Comments

@rsbivand
Copy link

@f8l5h9 00check.log is the log of a reverse depenency check showing failures in a vignette. In the affected block, you should use provinces_spain <- sf::st_make_valid(provinces_spain) after the first line, but the ggplot code remains broken anyway. spdep 1.3-1 will be submitted shortly.

@rsbivand
Copy link
Author

@f8l5h9 @paezha Is this package abandoned? It was archived on CRAN for not fixing issues within stipulated time. My current CMD check --as-cran log:
00check.log

@paezha
Copy link
Collaborator

paezha commented Jun 12, 2024

@rsbivand not abandoned, but @f8l5h9 has been dealing with a challenging situation at home, which has prevented him from making the fixes.

@f8l5h9 is there a way that @rominsal or I can do this?

@rsbivand
Copy link
Author

@paezha Thanks, I understand. While fixing the issues shouldn't be hard, submission to CRAN needs to be handled by @f8l5h9 as maintainer; transferring maintainership to some else also needs the maintainer to agree (by email to CRAN).

@rsbivand
Copy link
Author

rsbivand commented Oct 24, 2024

@f8l5h9 @paezha thanks for updating. The current problem is that rgeoda has severe issues with forthcoming clang++ 19, relying on BOOST qvm headers:

test-clang/BH/include/boost/qvm/quat_traits.hpp:82:30: error: a template argument list is expected after a name prefixed by the template keyword

boostorg/qvm#54, llvm/llvm-project#101079, eddelbuettel/bh#101, GeoDaCenter/rgeoda#49.

Since you do not import from rgeoda, could you move it from Imports: to Suggests: and condition any use - in R/local.jc.test.R on rgeoda being available? Would you like me to make a PR? I am very unsure whether the github repo was synchronised before 0.1.3.3 was submitted to CRAN - please do keep the repo ahead of or synched with CRAN.

@rsbivand rsbivand mentioned this issue Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants