Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumPy Versioning Issue #42

Closed
Bpoole908 opened this issue Oct 18, 2023 · 3 comments · Fixed by #43
Closed

NumPy Versioning Issue #42

Bpoole908 opened this issue Oct 18, 2023 · 3 comments · Fixed by #43

Comments

@Bpoole908
Copy link

Bpoole908 commented Oct 18, 2023

It looks like np.float is/has been deprecated in NumPy. Currently, GGLasso requires any version of NumPy >= 1.17.3. However, this breaks for versions of NumPy > 1.22.0 where np.float has been fully removed. Maybe this should be considered in the requirements or np.float usage should be updated?

@fabian-sp
Copy link
Owner

Thanks for pointing this out. I will replace np.float by np.float64,..

Somehow in Colab, if I install a numpy version > 1.22.0 it still seems to work though (I only get the DeprecationWarning).

@Bpoole908
Copy link
Author

Bpoole908 commented Oct 18, 2023

There could be additional versions that still throw the DeprecationWarning. I believe I originally observed that 1.25.2 throws a full error. I didn't test every version in-between sadly. I found 1.22.0 worked and went with that for now.

@fabian-sp fabian-sp linked a pull request Oct 20, 2023 that will close this issue
@fabian-sp
Copy link
Owner

I update the package (to version 0.1.10) and it should now also work with the newest versions of numpy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants