Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Add ReadonlyArray to Fable.Core #3946

Closed
wants to merge 1 commit into from

Conversation

MangelMaxime
Copy link
Member

@MangelMaxime MangelMaxime commented Oct 27, 2024

This is not a real JS type, but TypeScript makes extensive use of this type.

In the future, Glutinum will probably take over the responsibility of exposing such types but I am not sure yet how Glutinum packages should be shaped.

For now, I think exposing it via Fable.Core is fine. Looking at the git history it was originally part of Fable.Core but removed at some point not sure why.

Later on, we will be able to either remove the type again or keep it as no one will really use it outside of bindings.

@ncave @dbrattli

Do you think that's ok?

@ncave
Copy link
Collaborator

ncave commented Oct 27, 2024

@MangelMaxime I don't see a problem, perhaps add a note that it's only for TypeScript target.

@MangelMaxime
Copy link
Member Author

After a night of thinking, I think I will start a Glutinum.Types NuGet package because I am not sure how much more custom type I will need in the future.

And doing so, gives me the ability to experiments with module structure more freely by make breaking changes.

@MangelMaxime MangelMaxime deleted the feature/readonly_array branch October 28, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants