From a33b0a42e9859ad5bfe898c755600b72fcc7d32d Mon Sep 17 00:00:00 2001 From: Adam Jolicoeur Date: Tue, 20 Jun 2017 10:28:08 -0400 Subject: [PATCH 1/2] update to add BEM section --- code-guidelines.md | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/code-guidelines.md b/code-guidelines.md index 87c65c4..4d1cc38 100644 --- a/code-guidelines.md +++ b/code-guidelines.md @@ -437,38 +437,38 @@ Always use classes - avoid using an ID. Use classes over generic element tag for ``` - +- Each class name imparts structural info without binding to exact HTML. From f16060279c8c1371418b6f84caf0b83db0fab86a Mon Sep 17 00:00:00 2001 From: Adam Jolicoeur Date: Tue, 20 Jun 2017 12:01:45 -0400 Subject: [PATCH 2/2] update per PR review --- code-guidelines.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/code-guidelines.md b/code-guidelines.md index 4d1cc38..2381349 100644 --- a/code-guidelines.md +++ b/code-guidelines.md @@ -411,7 +411,7 @@ To avoid conflicts, OpenShift.io prefixes all classes with io-”. This also hel } // Good -.pf-selector { +.io-selector { ... } ``` @@ -450,7 +450,7 @@ Class name structure follows the `{{io-block}}__{{element}}--{{modifier}}` struc Example: ```html -
+

Heading