Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Custom liveness/readiness probes are not being created #1019

Closed
nicolaferraro opened this issue Aug 11, 2017 · 3 comments
Closed

Custom liveness/readiness probes are not being created #1019

nicolaferraro opened this issue Aug 11, 2017 · 3 comments
Assignees
Labels
cat/bug Bug which needs fixing group/enricher Enricher related group/xml-config XML configuration syntax related prio/p1 Normal priority size/m Medium

Comments

@nicolaferraro
Copy link
Member

The plugin should be already configured to create liveness/readiness probes from custom user definition, as in the following example:

<resources>
   <readiness>
      <getUrl>/monitor/</getUrl>
   </readiness>
</resources>

Anyway no probes seem to be generated by this configuration.
We should:

@cescoffier
Copy link
Contributor

@nicolaferraro I'm not sure the current config model does not support nested structure. See my other PR where I'm using the Maven configuration directly.

Right now, this does not work because the ResourceConfig does not have the readiness and liveness attributes (io.fabric8.maven.core.config.ResourceConfig:100).

@stale
Copy link

stale bot commented Oct 4, 2018

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Oct 4, 2018
@rhuss
Copy link
Contributor

rhuss commented Oct 6, 2018

@nicolaferraro you are right we should value XML configuration over enricher config when reconsidering the XML configuration in #18

@cescoffier afais this issue is about the XML config syntax in general, not for a an enricher config. Nevertheless we are thinking about a deeper configuration for enrichers via #1375

@stale stale bot removed the status/stale Issue/PR considered to be stale label Oct 6, 2018
@rhuss rhuss added cat/bug Bug which needs fixing prio/p1 Normal priority size/m Medium group/enricher Enricher related group/xml-config XML configuration syntax related labels Oct 6, 2018
@rohanKanojia rohanKanojia self-assigned this Nov 23, 2018
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Nov 23, 2018
…eated

Added CustomProbeEnricher for adding probes via XML config
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Nov 24, 2018
…eated

Added CustomProbeEnricher for adding probes via XML config
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Nov 24, 2018
…eated

Added CustomProbeEnricher for adding probes via XML config
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Nov 27, 2018
…eated

Added CustomProbeEnricher for adding probes via XML config
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Nov 27, 2018
…eated

Added CustomProbeEnricher for adding probes via XML config
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Nov 28, 2018
…eated

Added CustomProbeEnricher for adding probes via XML config
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Dec 11, 2018
…eated

Added CustomProbeEnricher for adding probes via XML config
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Dec 11, 2018
…eated

Added CustomProbeEnricher for adding probes via XML config
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Dec 12, 2018
…eated

Added CustomProbeEnricher for adding probes via XML config
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Dec 13, 2018
…eated

Added CustomProbeEnricher for adding probes via XML config
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Dec 13, 2018
…eated

Added CustomProbeEnricher for adding probes via XML config
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Dec 13, 2018
…eated

Added CustomProbeEnricher for adding probes via XML config
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Dec 13, 2018
…eated

Added CustomProbeEnricher for adding probes via XML config
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Dec 14, 2018
…eated

Added CustomProbeEnricher for adding probes via XML config
rohanKanojia added a commit to rohanKanojia/fabric8-maven-plugin that referenced this issue Dec 14, 2018
…eated

Added CustomProbeEnricher for adding probes via XML config
rhuss pushed a commit that referenced this issue Dec 14, 2018
Added CustomProbeEnricher for adding probes via XML config. Fixes #1019.
lordofthejars pushed a commit to lordofthejars/fabric8-maven-plugin that referenced this issue Jan 17, 2019
Added CustomProbeEnricher for adding probes via XML config. Fixes fabric8io#1019.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cat/bug Bug which needs fixing group/enricher Enricher related group/xml-config XML configuration syntax related prio/p1 Normal priority size/m Medium
Projects
None yet
Development

No branches or pull requests

5 participants