Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Optimize Kubernetes/OpenShift API access #1342

Open
rhuss opened this issue Jul 30, 2018 · 2 comments
Open

Optimize Kubernetes/OpenShift API access #1342

rhuss opened this issue Jul 30, 2018 · 2 comments
Labels
cat/techdebt Technical debt, like missing unit tests or tests status/never-stale Pin this issue to get never marked as stale by stale-bot target/3.5 PR targeted to 3.5

Comments

@rhuss
Copy link
Contributor

rhuss commented Jul 30, 2018

Description

The current way how the API client is created and how the decision is made whether an OpenShift or Kubernetes client should be used in burried mostly in ClusterAccess but also used differently e.g. in WatchMojo or Fabric8ServiceHub. It also looks like that during the detection phase some unnecessary API calls are performed.

Actually, this should be refactored:

  • That's there is only a single spot where the client is created
  • When the mode is specified, a cluster must not be called. This is especially important for offline mode, where the whole build slows down when this detection can't be performed

See #895 for a first start how the client could be created when the mode is known.

@rhuss rhuss added Refactoring target/3.5 PR targeted to 3.5 labels Jul 30, 2018
@rhuss rhuss added cat/techdebt Technical debt, like missing unit tests or tests and removed cat/techdebt Technical debt, like missing unit tests or tests cat/refactoring labels Sep 14, 2018
@stale
Copy link

stale bot commented Dec 13, 2018

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Dec 13, 2018
@rohanKanojia rohanKanojia removed the status/stale Issue/PR considered to be stale label Dec 13, 2018
@stale
Copy link

stale bot commented Mar 13, 2019

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Mar 13, 2019
@stale stale bot closed this as completed Mar 20, 2019
@rohanKanojia rohanKanojia reopened this Mar 20, 2019
@stale stale bot removed the status/stale Issue/PR considered to be stale label Mar 20, 2019
@rohanKanojia rohanKanojia added the status/never-stale Pin this issue to get never marked as stale by stale-bot label Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cat/techdebt Technical debt, like missing unit tests or tests status/never-stale Pin this issue to get never marked as stale by stale-bot target/3.5 PR targeted to 3.5
Projects
None yet
Development

No branches or pull requests

2 participants