How enable multi-selection for sub-targets of Group

[mikayelcreativefabrica]

Hey all. I am wondering if there is a way to enable multi-selection for sub-targets of Group

https://stackblitz.com/edit/vitejs-vite-p7fzzt?file=src%2Fmain.ts

[asturur]

I think shift + click should work, for the drag selection i m not 100% sure.
Can you please provide a working example of your setup?

[mikayelcreativefabrica]

https://stackblitz.com/edit/vitejs-vite-p7fzzt?file=src%2Fmain.ts This is a working example of the problem you have to wait several seconds to load the dependencies.

shift + click is working but the problem is reaching the same result with select-rectangle

[mikayelcreativefabrica]

as shown in the image.

[zhe-he]

I achieved this by overriding this method.

Canvas.prototype.collectObjects = function ({ left, top, width, height }, { includeIntersecting = true } = {}) {
    const objects: FabricObject[] = [];
    //...
    return objects;
}

[mikayelcreativefabrica]

thank you @zhe-he it works for me with a small mutation of the source code

Canvas.prototype.collectObjects = function (
      { left, top, width, height }: TBBox,
      { includeIntersecting = true }: { includeIntersecting?: boolean } = {},
    ) {
      const objects: InteractiveFabricObject[] = [],
        tl = new Point(left, top),
        br = tl.add(new Point(width, height))
      // we iterate reverse order to collect top first in case of click.
      for (let i = this._objects.length - 1; i >= 0; i--) {
        const object = this._objects[i] as unknown as InteractiveFabricObject
        if (
          object.selectable &&
          object.visible &&
          ((includeIntersecting && object.intersectsWithRect(tl, br)) ||
            object.isContainedWithinRect(tl, br) ||
            (includeIntersecting && object.containsPoint(tl)) ||
            (includeIntersecting && object.containsPoint(br)))
        ) {
          objects.push(object)
        } else if (object instanceof Group && object.subTargetCheck) {
          const subObject = Canvas.prototype.collectObjects.call(
            object,
            { left, top, width, height },
            { includeIntersecting },
          )
          objects.push(...subObject)
        }
      }

      return objects
    }

[asturur]

I need to understand if this is worth a feature or not. Not every interaction should be provided by fabric, i would argue a way to create interactions is more useful