Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoginAsync treats cancel the same as error #19

Closed
ghost opened this issue May 13, 2013 · 3 comments
Closed

LoginAsync treats cancel the same as error #19

ghost opened this issue May 13, 2013 · 3 comments

Comments

@ghost
Copy link

ghost commented May 13, 2013

When calling FacebookSessionClient.LoginAsync, there is no difference in the handling between when an error occurs (WebAuthenticationStatus.ErrorHttp) or when a user cancels the operation (WebAuthenticationStatus.UserCancel). Both result in a plain InvalidOperationException being thrown.

In practice, one might want to distinguish between the two. I want to do something different to my users when they press the back button as when, for example, the device has no internet connection. As it stands, there is no way to make this distinction.

@f2bo
Copy link
Contributor

f2bo commented May 13, 2013

+1

Returning more specific exceptions, or at least different error messages would be better.
@ntotten: we need this for the controls.

@ghost
Copy link
Author

ghost commented May 25, 2013

Turns out this is a duplicate of issue #17.

@sanjeevdwivedi
Copy link
Contributor

duplicate. Closing. See #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants