Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode #1620

Open
bhousel opened this issue Nov 21, 2024 · 1 comment
Open

Dark mode #1620

bhousel opened this issue Nov 21, 2024 · 1 comment
Labels
feature-usability Issue or feature related to usability - something hard to do

Comments

@bhousel
Copy link
Contributor

bhousel commented Nov 21, 2024

People seem really interested in Dark Mode lately 😆 🧛‍♂️

We should detect the user's prefers-dark-interface setting that we get from the browser and allow them to set a light/dark/automatic preference.
@bhousel bhousel added the feature-usability Issue or feature related to usability - something hard to do label Nov 21, 2024
bhousel added a commit that referenced this issue Nov 21, 2024
@bhousel
Detect some things with window.matchMedia
ceba2f3 
(re: #1620)

Also removed some things from `utilDetect` that aren't worth
detecting anymore now that we don't support very old browsers.

Also cleaned up the utilDetect tests, I'm not sure they were
actually working correctly because of caching.
@bhousel
Copy link
Contributor Author

bhousel commented Nov 27, 2024

Just flagging that Chrome/Webkit has an open issue where it's not honoring window.matchMedia('(prefers-color-scheme: dark)') in some cases, but there are workarounds. I did notice this when testing locally with Chrome.

https://stackoverflow.com/questions/78013261/why-window-matchmediaprefers-color-scheme-dark-matches-false-when-c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-usability Issue or feature related to usability - something hard to do
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bhousel