From 15abaa5b85c80ab25636ed851c7ba19d025a9b6b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1t=C3=A9=20Szab=C3=B3?= Date: Thu, 29 Aug 2024 18:07:25 -0700 Subject: [PATCH] Fix actions/upload-artifact deprecation (#2284) Summary: X-link: https://github.com/facebookincubator/zstrong/pull/970 actions/upload-artifact < v4 is deprecated and will not be supported after November 30, 2024.[1] Migrate to v4 instead -- the API used by fbcode_builder is not changed by this version bump. [1] https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ Pull Request resolved: https://github.com/facebook/folly/pull/2284 Reviewed By: yfeldblum Differential Revision: D61730024 Pulled By: Orvid fbshipit-source-id: 37eb13c6257a233ae170aa44aadeeb35a01568b1 --- .github/workflows/getdeps_linux.yml | 2 +- .github/workflows/getdeps_mac.yml | 2 +- .github/workflows/getdeps_windows.yml | 2 +- build/fbcode_builder/getdeps.py | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/getdeps_linux.yml b/.github/workflows/getdeps_linux.yml index 23bb3793029..be0d1ee7a2d 100644 --- a/.github/workflows/getdeps_linux.yml +++ b/.github/workflows/getdeps_linux.yml @@ -122,7 +122,7 @@ jobs: run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. folly --project-install-prefix folly:/usr/local - name: Copy artifacts run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fixup-dyn-deps --strip --src-dir=. folly _artifacts/linux --project-install-prefix folly:/usr/local --final-install-prefix /usr/local - - uses: actions/upload-artifact@v2 + - uses: actions/upload-artifact@v4 with: name: folly path: _artifacts diff --git a/.github/workflows/getdeps_mac.yml b/.github/workflows/getdeps_mac.yml index ee3f42db5e7..d00c5b5b927 100644 --- a/.github/workflows/getdeps_mac.yml +++ b/.github/workflows/getdeps_mac.yml @@ -110,7 +110,7 @@ jobs: run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. folly --project-install-prefix folly:/usr/local - name: Copy artifacts run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fixup-dyn-deps --src-dir=. folly _artifacts/mac --project-install-prefix folly:/usr/local --final-install-prefix /usr/local - - uses: actions/upload-artifact@v2 + - uses: actions/upload-artifact@v4 with: name: folly path: _artifacts diff --git a/.github/workflows/getdeps_windows.yml b/.github/workflows/getdeps_windows.yml index abc205f7095..4a5653be156 100644 --- a/.github/workflows/getdeps_windows.yml +++ b/.github/workflows/getdeps_windows.yml @@ -101,7 +101,7 @@ jobs: run: python build/fbcode_builder/getdeps.py build --src-dir=. folly - name: Copy artifacts run: python build/fbcode_builder/getdeps.py fixup-dyn-deps --src-dir=. folly _artifacts/windows --final-install-prefix /usr/local - - uses: actions/upload-artifact@v2 + - uses: actions/upload-artifact@v4 with: name: folly path: _artifacts diff --git a/build/fbcode_builder/getdeps.py b/build/fbcode_builder/getdeps.py index dfb028a94ce..ae12922f0ce 100755 --- a/build/fbcode_builder/getdeps.py +++ b/build/fbcode_builder/getdeps.py @@ -1180,7 +1180,7 @@ def write_job_for_platform(self, platform, args): # noqa: C901 f"--final-install-prefix /usr/local\n" ) - out.write(" - uses: actions/upload-artifact@v2\n") + out.write(" - uses: actions/upload-artifact@v4\n") out.write(" with:\n") out.write(" name: %s\n" % manifest.name) out.write(" path: _artifacts\n")