From 7f8f85ab0d713d7b10fa7f480c31c43cdabee6a8 Mon Sep 17 00:00:00 2001 From: Jon Janzen Date: Thu, 9 May 2024 09:11:15 -0700 Subject: [PATCH] Restrict build targets --- .github/scripts/bad_targets | 45 ++++++++++++++++++++++++++ .github/scripts/buck_build_and_test.sh | 5 ++- 2 files changed, 49 insertions(+), 1 deletion(-) create mode 100644 .github/scripts/bad_targets mode change 100644 => 100755 .github/scripts/buck_build_and_test.sh diff --git a/.github/scripts/bad_targets b/.github/scripts/bad_targets new file mode 100644 index 00000000000..4252b44a55c --- /dev/null +++ b/.github/scripts/bad_targets @@ -0,0 +1,45 @@ +# This is a list of bad targets that do not build in OSS. Ideally this list goes away +# with time. +root//folly/docs/examples/folly:baton_demo +root//folly/docs/examples/folly:cancellation_callback_demo +root//folly/docs/examples/folly:cancellation_source_demo +root//folly/docs/examples/folly:cancellation_token_demo +root//folly/docs/examples/folly:dynamic_converter_demo +root//folly/docs/examples/folly:dynamic_demo +root//folly/docs/examples/folly:executor_guide +root//folly/docs/examples/folly:file_demo +root//folly/docs/examples/folly:format_demo +root//folly/docs/examples/folly:function_demo +root//folly/docs/examples/folly:ipaddress_demo +root//folly/docs/examples/folly:likely_demo +root//folly/docs/examples/folly:map_util_demo +root//folly/docs/examples/folly:scope_guard_demo +root//folly/docs/examples/folly:scope_guard2_demo +root//folly/docs/examples/folly:scoped_event_base_thread_demo +root//folly/docs/examples/folly:scoped_event_base_thread2_demo +root//folly/docs/examples/folly:synchronized_demo +root//folly/docs/examples/folly/container:array_demo +root//folly/docs/examples/folly/dynamic:array_demo +root//folly/docs/examples/folly/dynamic:object_demo +root//folly/docs/examples/folly/experimental/coro:async_scope_demo +root//folly/docs/examples/folly/experimental/coro:cancellable_async_scope_demo +root//folly/docs/examples/folly/experimental/coro:detach_on_cancel_demo +root//folly/docs/examples/folly/experimental/coro:promise_demo +root//folly/docs/examples/folly/experimental/coro:retry_demo +root//folly/docs/examples/folly/experimental/coro:task_demo +root//folly/docs/examples/folly/experimental/coro:with_cancellation_demo +root//folly/docs/examples/folly/hash:hash_demo +root//folly/docs/examples/folly/io:i_o_buf_demo +root//folly/experimental/exception_tracer:exception_counter +root//folly/experimental/exception_tracer:exception_tracer +root//folly/experimental/exception_tracer:exception_tracer_callbacks +root//folly/experimental/exception_tracer:smart_exception_stack_trace_hooks +root//folly/experimental/exception_tracer:smart_exception_tracer +root//folly/experimental/symbolizer/tool:folly-addr2line +root//folly/experimental/symbolizer/tool:libFollySegFault.so +root//folly/logging/example:example +root//folly/python:executor_lib +root//folly/python:fibers_lib +root//folly/python:iobuf_lib +root//folly/tool:benchmark_compare +shim//third-party/libaio:aio__libaio__brew_headers diff --git a/.github/scripts/buck_build_and_test.sh b/.github/scripts/buck_build_and_test.sh old mode 100644 new mode 100755 index ebb726eb3f0..371fc03c2df --- a/.github/scripts/buck_build_and_test.sh +++ b/.github/scripts/buck_build_and_test.sh @@ -13,5 +13,8 @@ # See the License for the specific language governing permissions and # limitations under the License. +TARGETS_FILE=$(mktemp) +./buck2 targets //... | grep -F -v -f .github/scripts/bad_targets | grep -v test >$TARGETS_FILE -./buck2 build //... && ./buck2 test //... +./buck2 build @$TARGETS_FILE +# ./buck2 test @$TARGETS_FILE