fix NumberFormat.resolvedOptions on Android #1565
Conversation
|
Hi @dlindenkreuz! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
dlindenkreuz
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thanks for fixing this! |
|
@neildhar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey @dlindenkreuz, it looks like the newly added test is failing on both macOS and Android |
|
@dlindenkreuz has updated the pull request. You must reimport the pull request before landing. |
dlindenkreuz
force-pushed
the
patch-2
branch
from
02e71c5
to
dc569ff
Compare
|
@dlindenkreuz has updated the pull request. You must reimport the pull request before landing. |
|
Duh, forgot to commit some changes. |
|
@dlindenkreuz has updated the pull request. You must reimport the pull request before landing. |
|
@neildhar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Original Author: dan@xcllnc.de Original Git: 662354b Original Reviewed By: dannysu Original Revision: D65822468 A typo currently leads to wrong results for `NumberFormat.resolvedOptions()`: `minimumSignificantDigits` and `maximumSignificantDigits` are interchanged. This PR fixes that and adds tests. Pull Request resolved: #1565 Reviewed By: fbmal7 Differential Revision: D66135002 fbshipit-source-id: 8d469e3cb012cb5834785145c37dbad4b2d24e99
Summary
A typo currently leads to wrong results for
NumberFormat.resolvedOptions():minimumSignificantDigitsandmaximumSignificantDigitsare interchanged.This PR fixes that and adds tests.
Test Plan
Added unit tests.