Disable some tidy things in Configurable

Summary: As title. Reviewed By: wsanville Differential Revision: D65774065 fbshipit-source-id: a6877895be0cd5061023a829394fd3c9e862b51b
facebook · Nov 15, 2024 · 1b19aa1 · 1b19aa1
1 parent aa8f4b6
commit 1b19aa1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/libredex/Configurable.cpp b/libredex/Configurable.cpp
@@ -491,6 +491,7 @@ Json::Value Configurable::as<Json::Value>(const Json::Value& value,
   return value;
 }
 
+// NOLINTBEGIN(bugprone-macro-parentheses)
 #define IMPLEMENT_REFLECTOR(type)                                              \
   template <>                                                                  \
   void Configurable::reflect(                                                  \
@@ -540,6 +541,7 @@ Json::Value Configurable::as<Json::Value>(const Json::Value& value,
                                    const std::string& name, type value) { \
     reflector_trait(name, Json::Value(value));                            \
   }
+// NOLINTEND(bugprone-macro-parentheses)
 
 IMPLEMENT_REFLECTOR(float)
 IMPLEMENT_REFLECTOR_WITH_DFLT_VALUE(bool)

diff --git a/libredex/Configurable.h b/libredex/Configurable.h
@@ -184,7 +184,6 @@ class Configurable {
     Json::Value value;
   };
 
- public:
   virtual ~Configurable() {}
 
   /**
@@ -399,6 +398,7 @@ class Configurable {
 
 // Specializations for primitives
 
+// NOLINTBEGIN(bugprone-macro-parentheses)
 #define DEFINE_CONFIGURABLE_PRIMITIVE(T)                                  \
   template <>                                                             \
   T Configurable::as<T>(const Json::Value& value, bindflags_t bindflags); \
@@ -408,6 +408,7 @@ class Configurable {
       const std::string& param_doc, const bool param_is_required,         \
       const Configurable::bindflags_t param_bindflags, T& param,          \
       typename DefaultValueType<T>::type default_value);
+// NOLINTEND(bugprone-macro-parentheses)
 
 #define SINGLE_ARG(...) __VA_ARGS__
 DEFINE_CONFIGURABLE_PRIMITIVE(float)