Skip to content
This repository has been archived by the owner on Sep 1, 2024. It is now read-only.

[Feature Request] Support for Dreamers #143

Open
veds12 opened this issue Jan 18, 2022 · 10 comments
Open

[Feature Request] Support for Dreamers #143

veds12 opened this issue Jan 18, 2022 · 10 comments
Labels
enhancement New feature or request

Comments

@veds12
Copy link

veds12 commented Jan 18, 2022

🚀 Feature Request

Add support for Dreamer and Dreamerv2

Motivation

Dreamer and Dreamerv2 are important and current SOTA in mbrl. Few standard implementations are available for both Dreamer (rllib, author's implementation) and Dreamerv2 (author's implementation). Some good implementations include https://github.com/RajGhugare19/dreamerv2, https://github.com/juliusfrost/dreamer-pytorch and https://github.com/jurgisp/pydreamer

Pitch

Both Dreamer and Dreamerv2 can be written on top of planet

@veds12 veds12 added the enhancement New feature or request label Jan 18, 2022
@luisenp luisenp pinned this issue Jan 18, 2022
@luisenp
Copy link
Contributor

luisenp commented Jan 18, 2022

Hi @veds12. This is definitely at the top of my list of priorities for MBRL-Lib! I hope we can roll out an implementation in the next few months, but It's taking longer than I'd like since I have other commitments.

@natolambert
Copy link
Contributor

I would be interested in contributing @luisenp. Long time been on my list to study it.

@veds12
Copy link
Author

veds12 commented Jan 18, 2022

Thank you @luisenp and @natolambert !
@natolambert I would be interested in this as well. Please let me know (if / how) I can help :)

@luisenp
Copy link
Contributor

luisenp commented Jan 18, 2022

That sounds great! How about setting a VC the 3 of us to coordinate this week? Does Friday work for you? If you are interested, send me an email and I'll send an invite to that address. @veds12 @natolambert

@Rohan138
Copy link
Contributor

Rohan138 commented Apr 4, 2022

Hi! Just wanted to check in on progress on this; I'd be interested in contributing as well.

@luisenp
Copy link
Contributor

luisenp commented Apr 4, 2022

Hi @Rohan138. @veds12 opened a PR skeleton for this (#145), but there hasn't been a lot of progress lately, and I've been busy with other projects. Contributions are definitely welcome! I will also have more time after NeurIPS deadline to offer support/collaborate on this :)

@Rohan138
Copy link
Contributor

Rohan138 commented Jun 5, 2022

@luisenp Just opened a draft PR #151 ; mainly need to debug and clean up the dreamer loss calculation, then test it.

@luisenp
Copy link
Contributor

luisenp commented Jun 5, 2022

Awesome! I'll take a look this week and give feedback. Thanks a lot for contributing to the library!

@ManuelRios18
Copy link

#151

This PR is intended to implement DreamerV2?

@luisenp
Copy link
Contributor

luisenp commented Jul 11, 2022

Hi @ManuelRios18 that PR is intended to implement the original Dreamer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants