You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
vizseq.scorers.bleu.BLEUScorer does not use Tokenizer13a by default. When I look at the code, it looks like it should be used by default. sacrebleu library uses the Tokenizer13a by default as well.
The problem is here. Variable tokenizer is set to string none. When calling method get_default_args (here), default value 13a for parameter tokenize is not used, because the string none is passed.
Expected Behavior
vizseq.scorers.bleu.BLEUScorer should use Tokenizer13a by default.
System information
vizseq==0.1.15
python==3.7.3
macOS
The text was updated successfully, but these errors were encountered:
🐛 Bug
vizseq.scorers.bleu.BLEUScorer
does not useTokenizer13a
by default. When I look at the code, it looks like it should be used by default.sacrebleu
library uses theTokenizer13a
by default as well.To reproduce
Minimal Code/Config snippet to reproduce
Stack trace/error message
The problem is here. Variable
tokenizer
is set to stringnone
. When calling methodget_default_args
(here), default value13a
for parametertokenize
is not used, because the stringnone
is passed.Expected Behavior
vizseq.scorers.bleu.BLEUScorer
should useTokenizer13a
by default.System information
The text was updated successfully, but these errors were encountered: