New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESI tag not resolved on customer address book #51

Open

subbu1993 opened this issue Aug 20, 2020 · 0 comments

subbu1993 commented Aug 20, 2020

Preconditions

Magento 1.14.3.0
Fastly - 1.0.26

issue

Log into a customer account
Go to the address book page
Delete address

Expected result

Address is deleted

Actual result

Address is not deleted

Details

The deleteAddress method defined in https://github.com/OpenMage/magento-mirror/blob/98da842ef7aa59b8b8fee642de8b0b6deec55c31/app/design/frontend/base/default/template/customer/address/book.phtml#L100 uses a form key
The form key is converted to an ESI tag per fastly

window.location='https://xxxxxx.com/customer/address/delete/form_key/<esi:include src='http://xxxxx.net/fastlycdn/getformkey/' />/id/'+addressId;

This formkey esi tag is never parsed via the fastly VCL to actually get the form key for the user

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment