-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.0 #652
Closed
Closed
Release 3.0 #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ro-serializer-6.2.2 Update kafka-avro-serializer to 6.2.2 in series/3.x
…ainers-scala-kafka-0.39.12 Update testcontainers-scala-kafka, ... to 0.39.12 in series/3.x
…-2.2.24 Update sbt-mdoc to 2.2.24 in series/3.x
…-3.1.6 Update fs2-core to 3.1.6 in series/3.x
…ibrary-3.1.0 Update scala3-library to 3.1.0 in series/3.x
…oc-0.5.0 Update sbt-unidoc to 0.5.0 in series/3.x
…elease-1.5.10 Update sbt-ci-release to 1.5.10 in series/3.x
…ect-3.3.3 Update cats-effect, cats-effect-laws, ... to 3.3.3 in series/3.x
…-3.2.4 Update fs2-core to 3.2.4 in series/3.x
…ro-serializer-7.0.1 Update kafka-avro-serializer to 7.0.1 in series/3.x
…avro-serializer-7.0.1 Revert "Update kafka-avro-serializer to 7.0.1 in series/3.x"
…brary-2.13.8 Update scala-library to 2.13.8 in series/3.x
Executed command: sbt tlPrePrBotHook
…elevel-0.4.20 Update sbt-typelevel to 0.4.20 in series/3.x
Merge 2.x into 3.x
FakeFiber was used by KafkaConsumer to manage: 1. the consumerActor fiber, processing requests (including polls); 2. the pollScheduler fiber, scheduling poll requests (subject to backpressure); 3. a fiber combining the above two fibers. Compared to a regular fiber, FakeFiber offered a method to combine two fibers by racing them one against the other. The semantics were similar to the race method for effects, but operating at the fiber level. In KafkaConsumer, FakeFiber was used with cancellation effects that returned immediately (i.e., fiber.cancel.start.void). In addition the fiber outcome was relayed to KafkaConsumer.awaitTermination. With this change FakeFiber is replaced with an Async[F].race of the underlying effects. This is managed in the new method startBackgroundConsumer, which builds upon effects assembled by runConsumerActor and runPollScheduler. These effects are unwrapped from the previous fibers. As before, cancellation of the consumer effect is only waited on in awaitTermination, where any errors are propagated. Compared to the original behaviour of FakeFiber.combine, starting with cats-effect 3.5.0, cancellation of one of the consumer effects will lead to cancellation of both, as per changes introduced with typelevel/cats-effect#3453. I'm not sure how cancelation would come into play here, but the behaviour change looks appropriate: without one of the racing fibers KafkaConsumer would not be functional (no polls scheduled, or no requests/polls processed).
Update sbt to 1.8.3 in series/3.x
…a-plugin-1.1.3 Update sbt-mima-plugin to 1.1.3 in series/3.x
…lients-3.4.1 Update kafka-clients to 3.4.1 in series/3.x
…vro-serializer-7.3.4 Update kafka-avro-serializer to 7.3.4 in series/3.x
Bump CE and fs2 to the latest version
Retire FakeFiber
* Update sbt-typelevel to 0.5.3 in series/3.x * Exclude some Scala 3 compiler options added in 0.5.3
Co-authored-by: Dany Yanev <dany.yanev@qomplx.com>
Co-authored-by: Alan Artigao Carreño <alanartigao@gmail.com>
series/2.x reached end-of-life 🖖🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created for visibility of changes with 2.x