-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stuffing _7.dxf with _12.dxf #16
Comments
Sorry I didn't catch.. Does this problem also exist in the original DeepNest project? |
Yes, it's a limitation of the C++ import. Didn't know where the problem was coming from when first asked. Clipper isn't substitutable easily, trying to see why not or find an alternative implementation.
|
Actually, C++ portion of code is just a wrapper for the boost polygons convolve operation. I'll try to add a feature to choose C++/C# pure implementation. |
Clipper fares no better unfortunately but losing the C++ dependency altogether is an interesting proposition; revealed a bug in the caching I put in though (just as well you didn't adapt that bit) but simply isn't performant without the caching. Can confirm it seems to generate more invalid nests - but I'm not yet convinced that that's purely down to Clipper. @petrasvestartas re original DeepNest C# Port #34 and @dharani811 |
Havent been nesting lately :( wish i was able to help |
Curious why you've added the C part to the DXF samples. Have you done any work to understand why the following happens (using some more of the sample shapes you've included):
The full donut I've added and the original DeepNest and the Port are quite happy to place the smaller parts in the hole, but the C part you had never gets filled.
DeepNestPort/DeepNestLib/Background.cs
Line 1189 in 50dad9f
Noting the comment about holes in Background.cs (and the limitations of the C++ import) shouldn't the hole in the C shape be serviced by the OuterNfp?
The text was updated successfully, but these errors were encountered: