Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hash selector as last argument to property #78

Open
elhil opened this issue Mar 4, 2018 · 0 comments
Open

Allow hash selector as last argument to property #78

elhil opened this issue Mar 4, 2018 · 0 comments

Comments

@elhil
Copy link

elhil commented Mar 4, 2018

Small API improvement idea: instead of

stuff({ css: 'div.some-class' }, :list)

I want to be able to write:

stuff :list, css: 'div.some-class'

To me, this reads more like idiomatic ruby.

For the edge case where a user specifies both positional and hash arguments, we could just accept the first one? Or merge the two?

If you think this is worth it, I'd be happy to make a PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant