Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible security issue with temporary-file-directory #4

Open
errge opened this issue Jan 20, 2019 · 0 comments
Open

possible security issue with temporary-file-directory #4

errge opened this issue Jan 20, 2019 · 0 comments

Comments

@errge
Copy link

errge commented Jan 20, 2019

sync-recentf/sync-recentf.el

Line 64 in 0052561

(concat temporary-file-directory "sync-recentf-marker")

temporary-file-directory points to /tmp on a standard emacs installation. Opening any file in that directory with a known, non-randomized filename ("sync-recentf-marker") is a very bad idea... If the attacker can time operations and can create symlinks in /tmp, you can have random security issues.

I think you can simply change this to user-emacs-directory without losing anything.
msin32 added a commit to msin32/sync-recentf that referenced this issue Jun 15, 2024
@msin32
fix possible security issue
1d9263c 
ffevotte#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@errge