Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add footer to home page and switch current to returning #14

Merged
merged 13 commits into from
Nov 20, 2024

Conversation

kweav
Copy link
Contributor

@kweav kweav commented Oct 22, 2024

Per Issue #13, switching the language from current user to returning user. This required changes to the codebook (e.g., column names), tidying data steps, the main and extra analyses, and the descriptions throughout.

Tested the tidy, main, and extra Rmd's locally to verify that they knit properly and the plots looked as expected.

Also edited the flowchart (housed on a google slide), redownloaded the image, added it here, and added a commented out link to the slide deck on the homepage.

Added a footer to only the homepage about funding. This required edits to the style.css file as well as adding a footer.html file, and editing the YAML metadata header of the homepage.

Copy link
Contributor

github-actions bot commented Oct 22, 2024

No spelling errors! 🎉
Comment updated at 2024-11-20-00:47:49 with changes from d8d2f9c

Copy link
Contributor

github-actions bot commented Oct 22, 2024

⚠️ broken url errors ⚠️
There are broken url errors that need to be addressed.
Click here ➡️ for broken url errors!
Add errors that aren't errors to the resources/ignore-urls.txt file of this repo.
If you are having troubles see this guide
Comment updated at 2024-11-20-00:47:53 with changes from d8d2f9c

Copy link
Contributor

github-actions bot commented Oct 22, 2024

👀 Quick preview of website here *
🔬 Comprehensive download of the website here

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2024-11-20 with changes from the latest commit d8d2f9c

@kweav
Copy link
Contributor Author

kweav commented Oct 22, 2024

The preview won't show the flowchart, but that's because it's pointing to the link for the image when it is on main. That's also the URL error. But I've double checked the URL will be correct.

Not sure why I don't see the footer on the preview

@kweav kweav requested a review from avahoffman October 22, 2024 20:29
Copy link
Contributor

@avahoffman avahoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor changes! I think adding the footer to all pages (via _site.yml) should resolve the preview issue.

Missed occurrences in README.md:

  * `IdentifyTypeOfUsers.Rmd` -- analysis for the first question of the poll that allowed us to identify respondents as either potential or current users of the AnVIL.
analysis for poll questions asked only to current AnVIL users

@@ -16,16 +16,16 @@ codebook
CSER
CSHL
css
CurrentAnVIL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An option to keep these variable names from triggering the spell check is to use backticks, eg, `CurrentAnVIL`.. this has the added benefit of formatting it like code, as well.

pages/index.Rmd Outdated
@@ -1,15 +1,16 @@
---
title: "**About the AnVIL Community Poll**"
output:
html_document
html_document:
after_body: resources/footer.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this to the _site.yml file

pages/resources/footer.html Show resolved Hide resolved
kweav and others added 3 commits November 8, 2024 13:01
Switch out `separate` and `pivot_longer` functions for `separate_longer_delim`
AMH add horizontal separator

Co-authored-by: ava 🌱 <avamariehoffman@gmail.com>
@kweav
Copy link
Contributor Author

kweav commented Nov 8, 2024

Looks good, just a few minor changes! I think adding the footer to all pages (via _site.yml) should resolve the preview issue.

Missed occurrences in README.md:

  * `IdentifyTypeOfUsers.Rmd` -- analysis for the first question of the poll that allowed us to identify respondents as either potential or current users of the AnVIL.
analysis for poll questions asked only to current AnVIL users

Thanks for finding these and pointing them out!

@kweav
Copy link
Contributor Author

kweav commented Nov 8, 2024

@avahoffman do you think the footer has small enough text in the preview or should it be smaller?

@avahoffman
Copy link
Contributor

@avahoffman do you think the footer has small enough text in the preview or should it be smaller?

I might make it a size smaller than the main text. Thanks!

styles.css Outdated Show resolved Hide resolved
decrease footer size
@kweav
Copy link
Contributor Author

kweav commented Nov 20, 2024

Looking at the preview after the change I made to reduce the footer size -- I'm not sure it actually reduced the text size. Do you know what I might be missing?

@kweav kweav merged commit 9e71f69 into main Nov 20, 2024
5 of 6 checks passed
@kweav kweav deleted the currentToReturning branch November 20, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants