-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add footer to home page and switch current to returning #14
Conversation
No spelling errors! 🎉 |
|
👀 Quick preview of website here * * note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea. Updated at 2024-11-20 with changes from the latest commit d8d2f9c |
The preview won't show the flowchart, but that's because it's pointing to the link for the image when it is on main. That's also the URL error. But I've double checked the URL will be correct. Not sure why I don't see the footer on the preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few minor changes! I think adding the footer to all pages (via _site.yml) should resolve the preview issue.
Missed occurrences in README.md
:
* `IdentifyTypeOfUsers.Rmd` -- analysis for the first question of the poll that allowed us to identify respondents as either potential or current users of the AnVIL.
analysis for poll questions asked only to current AnVIL users
@@ -16,16 +16,16 @@ codebook | |||
CSER | |||
CSHL | |||
css | |||
CurrentAnVIL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An option to keep these variable names from triggering the spell check is to use backticks, eg, `CurrentAnVIL`
.. this has the added benefit of formatting it like code, as well.
pages/index.Rmd
Outdated
@@ -1,15 +1,16 @@ | |||
--- | |||
title: "**About the AnVIL Community Poll**" | |||
output: | |||
html_document | |||
html_document: | |||
after_body: resources/footer.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this to the _site.yml file
Forum awareness redo
Switch out `separate` and `pivot_longer` functions for `separate_longer_delim`
AMH add horizontal separator Co-authored-by: ava 🌱 <avamariehoffman@gmail.com>
Thanks for finding these and pointing them out! |
@avahoffman do you think the footer has small enough text in the preview or should it be smaller? |
I might make it a size smaller than the main text. Thanks! |
decrease footer size
Looking at the preview after the change I made to reduce the footer size -- I'm not sure it actually reduced the text size. Do you know what I might be missing? |
Per Issue #13, switching the language from current user to returning user. This required changes to the codebook (e.g., column names), tidying data steps, the main and extra analyses, and the descriptions throughout.
Tested the tidy, main, and extra Rmd's locally to verify that they knit properly and the plots looked as expected.
Also edited the flowchart (housed on a google slide), redownloaded the image, added it here, and added a commented out link to the slide deck on the homepage.
Added a footer to only the homepage about funding. This required edits to the style.css file as well as adding a footer.html file, and editing the YAML metadata header of the homepage.