Add input validation in get_device_serial() function

Add const to char *cmd Signed-off-by: Shrikant Temburwar <shrikant.temburwar@intel.com>
fido-device-onboard · Nov 20, 2023 · 452b689 · 452b689
1 parent 0f18bae
commit 452b689
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/storage/util.c b/storage/util.c
@@ -323,11 +323,18 @@ int print_timestamp(void)
 }
 
 #if defined(GET_DEV_SERIAL)
-// Get device serial number
+/**
+ * Internal API
+ * Get device serial number from system BIOS table
+ * */
 int get_device_serial(char *serial_buff)
 {
+	if (!serial_buff) {
+		return -1;
+	}
+
 	FILE *fp;
-	char *cmd = "dmidecode -s system-serial-number";
+	const char *cmd = "dmidecode -s system-serial-number";
 	int out_sz;
 	char out[MAX_DEV_SERIAL_SZ];
 	int results_sz = 0;